test: harden integration tests against transient API blips#47
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verified the new client-injection APIs exist and are used correctly, the reqwest dev-dependency/feature-unification reasoning is accurate, live-API test coverage is consistent (local wiremock tests correctly excluded), and the CI retry loop is correct under GHA's default bash shell. Clean change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration tests run sequentially against the live API and were intermittently failing on transient TCP connect timeouts: the client had no connect timeout and the suite had no retry, so a brief outage produced a ~20-minute red run needing a manual re-run. This bounds the test client's connect timeout (so a dead host fails fast) and retries the suite up to 3× with backoff in CI.